Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected Results when requesting companies containing special characters #146

Closed
joramkuntze opened this issue Jun 15, 2024 · 3 comments
Closed

Comments

@joramkuntze
Copy link

When searching for companies containing special characters like &. For example when searching for "A & W Tiefbau GmbH" one gets results just for "A", because & is not URL encoded.
A solution would be to convert company_name using urllib.parse.quote_plus(company_name)

@wirthual
Copy link
Member

Hi,

thanks for reporting. I think this got fixed in this PR #143

We are working on a new release. Otherwise you can always build the package from source :)

@wirthual
Copy link
Member

0.4.2 was just released and should fix this.

Tried it on my end:

Python 3.10.12 (main, Nov 20 2023, 15:14:05) [GCC 11.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from deutschland.bundesanzeiger import Bundesanzeiger
>>> 
>>> ba = Bundesanzeiger()
>>> 
>>> data = ba.get_reports("A & W Tiefbau GmbH")

>>> 
>>> print(len(data))
20

Let me know if that works for you as well.

@joramkuntze
Copy link
Author

Oh I didn't look in the up to date file. These changes already had been made. Now it works as expected. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants