-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transitioning from module linking to the component model #4303
Comments
I hijacked today's wasmtime project meeting to discuss this and had a very enlightening conversation with @alexcrichton and @fitzgen about it. Here are my takeaways:
@alexcrichton perhaps you could clarify the last point, since I'm not sure I understood it. Would there be two variants of |
Sure yeah, my current thinking is that |
Also, for concrete work items, I'm trying to keep the main tracking issue up-to-date and the "Separate work items" category should all be issues that are standalone (ish) and possible to implement in parallel. (although I still wouldn't classify any of them as "easy") |
This updates to `wasmtime` v0.38.0. Because module linking support has been removed from `wasmtime` as of v0.36.0, and the component model implementation is not yet mature enough to use as a replacement (see bytecodealliance/wasmtime#4303 for details), it is necessary to temporarily disable the Spidermonkey tests. I've done this by commenting-out the broken code in `instantiate_smw`, prefixed its name with and underscore, and renamed the relevant host.rs files to ignore_host.rs to hide them from the test infrastructure. Once the component model implementation is mature enough and the broader ecosystem has been updated to use it, we can update and restore these tests. Signed-off-by: Joel Dice <[email protected]>
This updates to `wasmtime` v0.38.0. Because module linking support has been removed from `wasmtime` as of v0.36.0, and the component model implementation is not yet mature enough to use as a replacement (see bytecodealliance/wasmtime#4303 for details), it is necessary to temporarily disable the Spidermonkey tests. I've done this by commenting-out the broken code in `instantiate_smw`, prefixed its name with and underscore, and renamed the relevant host.rs files to ignore_host.rs to hide them from the test infrastructure. Once the component model implementation is mature enough and the broader ecosystem has been updated to use it, we can update and restore the Spidermonkey tests. fixes bytecodealliance#259 Signed-off-by: Joel Dice <[email protected]>
I think the original questions here have been addressed, so I'm going to close this. Thanks for your help, Alex! |
This updates to `wasmtime` v0.38.0. Because module linking support has been removed from `wasmtime` as of v0.36.0, and the component model implementation is not yet mature enough to use as a replacement (see bytecodealliance/wasmtime#4303 for details), it is necessary to temporarily disable the Spidermonkey tests. I've done this by commenting-out the broken code in `instantiate_smw`, prefixed its name with and underscore, and renamed the relevant host.rs files to ignore_host.rs to hide them from the test infrastructure. Once the component model implementation is mature enough and the broader ecosystem has been updated to use it, we can update and restore the Spidermonkey tests. fixes #259 Signed-off-by: Joel Dice <[email protected]>
This updates to `wasmtime` v0.38.0. Because module linking support has been removed from `wasmtime` as of v0.36.0, and the component model implementation is not yet mature enough to use as a replacement (see bytecodealliance/wasmtime#4303 for details), it is necessary to temporarily disable the Spidermonkey tests. I've done this by commenting-out the broken code in `instantiate_smw`, prefixed its name with and underscore, and renamed the relevant host.rs files to ignore_host.rs to hide them from the test infrastructure. Once the component model implementation is mature enough and the broader ecosystem has been updated to use it, we can update and restore the Spidermonkey tests. fixes bytecodealliance/wit-bindgen#259 Signed-off-by: Joel Dice <[email protected]>
Per bytecodealliance/wit-bindgen#259, I'm interested in upgrading the
wasmtime
dependency inwit-bindgen
, and that has raised a more general question, which I'd like to ask here:What's the vision for code which previously used module linking and will eventually need to transition to the component model? Will there be a simple recipe to follow, or will big (e.g. architectural) changes be necessary?
Whatever that vision is, I'd be interested to help implement it if there are opportunities to do so without distracting from the work already in progress.
The text was updated successfully, but these errors were encountered: