From d2bb276c73f5c17f0bc5143c11518dbf8cf8daed Mon Sep 17 00:00:00 2001 From: Nuno Bento Date: Fri, 15 Nov 2024 21:02:58 +0000 Subject: [PATCH] Remove unused noauthsessionservice property (#11169) --- README.md | 2 +- docs/development/session-service-working.md | 2 -- .../java/org/cbioportal/security/config/ApiSecurityConfig.java | 2 +- 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index faed4f72e5f..8039031d85f 100644 --- a/README.md +++ b/README.md @@ -52,7 +52,7 @@ This should open the ports. Now we are ready to run the cBioPortal web app local ``` java -Xms2g -Xmx4g \ - -Dauthenticate=noauthsessionservice \ + -Dauthenticate=false \ -Dsession.service.url=http://localhost:5000/api/sessions/my_portal/ \ -Dsession.service.origin='*' \ -Dspring.datasource.username=cbio_user \ diff --git a/docs/development/session-service-working.md b/docs/development/session-service-working.md index 63769781e51..4c77eef698f 100644 --- a/docs/development/session-service-working.md +++ b/docs/development/session-service-working.md @@ -13,8 +13,6 @@ Here are the properties that needs to be set ``` -WARNING: do not use session service with -Dauthenticate=false - either use authentication or change to -Dauthenticate=noauthsessionservice session.service.url= #if basic authentication is enabled on session service one should set: session.service.user= diff --git a/src/main/java/org/cbioportal/security/config/ApiSecurityConfig.java b/src/main/java/org/cbioportal/security/config/ApiSecurityConfig.java index 0719a081ddb..b83524d0869 100644 --- a/src/main/java/org/cbioportal/security/config/ApiSecurityConfig.java +++ b/src/main/java/org/cbioportal/security/config/ApiSecurityConfig.java @@ -23,7 +23,7 @@ import org.springframework.security.web.util.matcher.AntPathRequestMatcher; @Configuration -@ConditionalOnProperty(name = "authenticate", havingValue = {"false", "noauthsessionservice", "optional_oauth2"}, isNot = true) +@ConditionalOnProperty(name = "authenticate", havingValue = {"false", "optional_oauth2"}, isNot = true) public class ApiSecurityConfig { // Add security filter chains that handle calls to the API endpoints.