Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-rebase #80

Open
Jericho opened this issue Aug 23, 2019 · 7 comments
Open

Auto-rebase #80

Jericho opened this issue Aug 23, 2019 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@Jericho
Copy link
Member

Jericho commented Aug 23, 2019

I need to investigate if I can ensure branches created for PRs can be kept updated.

This was suggested by @AdmiringWorm during this morning's @gep13 live Twitch session.

@Jericho Jericho added the enhancement New feature or request label Aug 23, 2019
@Jericho Jericho self-assigned this Aug 23, 2019
@AdmiringWorm
Copy link
Member

While it would be awesome if the addin discoverer could auto-rebase pull requests, as I said on the stream I do believe that it would probably be out-of-scope for the addin discoverers purpose.

Auto-rebasing would probably be better to be implemented as a github action in the necessary repositories instead (if possible).

That is just my own personal opinion of course.

@Jericho
Copy link
Member Author

Jericho commented Aug 29, 2019

I was also wondering what to do if there are conflicts? I highly doubt I would be able to automate conflict resolution.

@AdmiringWorm
Copy link
Member

I would think to regenerate/recreate the yaml file from the latest sources (basically what you already do when initially creating the the pr), then do a force push to replace the existing commit on the PR.

I think that is the approach that dependabot uses (the only one I know of that support auto-rebase, or rather auto-recreate).

@Jericho
Copy link
Member Author

Jericho commented Aug 29, 2019

that's a very good idea.

@AdmiringWorm
Copy link
Member

I have my moments 😄

@gep13
Copy link
Member

gep13 commented Aug 29, 2019

@AdmiringWorm I am watching with interest the addins that are being created here: https://github.com/repo-sync as I think they will be very useful.

@AdmiringWorm
Copy link
Member

@gep13 the pull request repo there was exactly the one I was thinking about when I said

Auto-rebasing would probably be better to be implemented as a github action in the necessary repositories instead (if possible).

But couldn't remember what the action I had seen was called 😢.

The other two repos I didn't know about though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants