Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Online status for nodes using username and password broken #1863

Open
slack2450 opened this issue Dec 8, 2024 · 0 comments
Open

Online status for nodes using username and password broken #1863

slack2450 opened this issue Dec 8, 2024 · 0 comments
Assignees
Labels
Bug Something isn't working

Comments

@slack2450
Copy link

Describe the bug
Cake wallet shows a red circle next to nodes using username and password. Disabling username and password makes this show green.

Looking through the code this section appears to be the issue:
https://github.com/cake-tech/cake_wallet/blob/main/cw_core/lib/node.dart#L196

I don't see the nonce for the session being sent, I believe that we should fetch the nonce first if using authentication and send this in the request to check if a node is online.

Here is where monerod checks for a valid nonce:
https://github.com/monero-project/monero/blob/master/contrib/epee/src/http_auth.cpp#L326

If a nonce is not provided or is stale it will return a 401 unauthorized response. This results in online checks always failing.

Platform:

  • OS: iOS
  • Device: iPhone 15
  • Cake Wallet Version: 4.21.2
@slack2450 slack2450 added the Bug Something isn't working label Dec 8, 2024
@MrCyjaneK MrCyjaneK self-assigned this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants