Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initialCheck? #4

Open
corysimmons opened this issue Dec 20, 2017 · 6 comments
Open

initialCheck? #4

corysimmons opened this issue Dec 20, 2017 · 6 comments

Comments

@corysimmons
Copy link

Plz?

@callumacrae
Copy link
Owner

?

@corysimmons
Copy link
Author

Transforms and such aren't applied if you refresh. You have to scroll.

In your when-scroll lib, you have initialCheck for this.

@callumacrae
Copy link
Owner

what browser is this in? in chrome, it fires the scroll event on page load if the document isn't at the top

i agree that this would be a good change to make. i probably wouldn't make it an option though, i'd just make it happen automatically

@corysimmons
Copy link
Author

corysimmons commented Dec 20, 2017

Latest Chrome, Macbook
I'm using your lib within React and have an element rotated. When I refresh the page, it is unrotated.

@callumacrae
Copy link
Owner

yep, that shouldn't happen.

PR welcome, or I'll get around to looking at it at some point :)

@corysimmons
Copy link
Author

Probably just gonna go with some ScrollMagic/GSAP 💩 for now, but if I find some time I'd like to fork your lib over to intuitive React components. If/when I do that, I'll add in this little bits and ping you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants