From 93f8c1d0717e468fa756ea43288ac53698651cb0 Mon Sep 17 00:00:00 2001 From: mh Date: Wed, 30 Aug 2017 18:52:16 +0200 Subject: [PATCH 1/3] the ensure param was completely dropped with the latest version --- manifests/acl.pp | 1 - manifests/mx.pp | 1 - manifests/record.pp | 1 - 3 files changed, 3 deletions(-) diff --git a/manifests/acl.pp b/manifests/acl.pp index 55a71d4..c16e8b2 100644 --- a/manifests/acl.pp +++ b/manifests/acl.pp @@ -25,7 +25,6 @@ } concat::fragment {"acl.${_name}": - ensure => $ensure, content => "include \"${bind::params::acls_directory}/${_name}\";\n", notify => Exec['reload bind9'], target => "${bind::params::config_base_dir}/acls.conf", diff --git a/manifests/mx.pp b/manifests/mx.pp index e25ce0a..b983f2f 100644 --- a/manifests/mx.pp +++ b/manifests/mx.pp @@ -34,7 +34,6 @@ if $ensure == 'present' { concat::fragment {"bind.${name}": - ensure => $ensure, target => "${bind::params::pri_directory}/${zone}.conf", content => template('bind/mx-record.erb'), notify => Service['bind9'], diff --git a/manifests/record.pp b/manifests/record.pp index bc5e5a1..97a3e96 100644 --- a/manifests/record.pp +++ b/manifests/record.pp @@ -59,7 +59,6 @@ if $ensure == 'present' { concat::fragment {"${zone}.${record_type}.${name}": - ensure => $ensure, target => "${bind::params::pri_directory}/${zone}.conf", content => $record_content, order => '10', From 7801b5430c0e357de28908eb7c41d8f46cdae74b Mon Sep 17 00:00:00 2001 From: mh Date: Wed, 30 Aug 2017 22:02:31 +0200 Subject: [PATCH 2/3] I don't think concat ever had a force param --- manifests/config.pp | 2 -- manifests/view.pp | 1 - 2 files changed, 3 deletions(-) diff --git a/manifests/config.pp b/manifests/config.pp index 934285c..9043de2 100644 --- a/manifests/config.pp +++ b/manifests/config.pp @@ -5,11 +5,9 @@ owner => root, group => $bind::params::bind_group, mode => '0644', - force => true, } concat {"${bind::params::config_base_dir}/acls.conf": - force => true, group => 'root', mode => '0644', owner => 'root', diff --git a/manifests/view.pp b/manifests/view.pp index 11ee7da..2d18171 100644 --- a/manifests/view.pp +++ b/manifests/view.pp @@ -26,7 +26,6 @@ if $ensure == 'present' { concat {"${bind::params::views_directory}/${_name}.zones": - force => true, group => 'root', mode => '0644', owner => 'root', From d2ca441dc5df7148360310c9be0e996c5d7dfcdb Mon Sep 17 00:00:00 2001 From: mh Date: Wed, 30 Aug 2017 22:30:56 +0200 Subject: [PATCH 3/3] tested with 4.0.1 --- metadata.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/metadata.json b/metadata.json index ff26aee..f9218fe 100644 --- a/metadata.json +++ b/metadata.json @@ -37,7 +37,7 @@ }, { "name": "puppetlabs/concat", - "version_requirement": ">= 1.0.0 <2.0.0" + "version_requirement": ">= 1.0.0 <5.0.0" } ] }