Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specimen.analyte_concentration_method name #18

Open
hsolbrig opened this issue Mar 25, 2021 · 2 comments
Open

Specimen.analyte_concentration_method name #18

hsolbrig opened this issue Mar 25, 2021 · 2 comments
Assignees

Comments

@hsolbrig
Copy link

This name is confusing -- this should be the method to measure the analyte concentration, not the means of concentrating the analyte

@bfurner
Copy link
Collaborator

bfurner commented Mar 29, 2021

@mbrush can you have a think about this?

@mbrush
Copy link
Contributor

mbrush commented Mar 29, 2021

I agree with Harold's assessment. I am trying to keep fields names as short as possible but still clear/unambiguous. This can be hard when the model is so denormalized, but I digress.

For this specific issue, lets consider the following alternatives to "analyte_concentration_method" (keeping in mind that this field is paired with the "analyte_concentration" field that holds the measured concentration):

  • "analyte_concentration_measurement_method"
  • "analyte_concentration_determination_method"
  • "analyte_concentration_determined_by"

These are all a mouthful, but more clearly describe what the field captures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants