Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insufficient integration tests for Knative components #148

Open
orfeas-k opened this issue Sep 1, 2023 · 1 comment
Open

Insufficient integration tests for Knative components #148

orfeas-k opened this issue Sep 1, 2023 · 1 comment

Comments

@orfeas-k
Copy link
Contributor

orfeas-k commented Sep 1, 2023

We should add more integration tests for Knative components, taking into account that knative-serving and knative-eventing charms should not just go to Active but also spin up deployments and pods in their corresponding namespaces. At the moment, we do not have sufficient tests for this and that's probably how we updated their version (PR #135) and ended up with knative-serving and eventing not being functional (issue #147).

@orfeas-k orfeas-k changed the title Insufficient tests for Knative components Insufficient integration tests for Knative components Sep 1, 2023
@orfeas-k
Copy link
Contributor Author

An update to this since we discussed a bit with @NohaIhab. Fact is that that we do have tests that deploy a KSVC and check that the KSVC response has 200 status. Should we have though tests that check that the deployments created in the corresponding namespaces (knative-eventing and knative-serving) during the charms' deployment complete? I 'm not sure if we have discussed this. If not, we can close this issue. But if yes, we should have a task for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs discussion
Development

No branches or pull requests

1 participant