Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests to kserve server rocks #47

Open
ca-scribner opened this issue Mar 7, 2024 · 2 comments
Open

Add integration tests to kserve server rocks #47

ca-scribner opened this issue Mar 7, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@ca-scribner
Copy link
Contributor

Context

The servers in this repo have simple integration tests described in their respective readme.md files - we should automate these and use them for CI/manual testing.

I tried looking into this a bit and what I got hung up on was how we needed to docker run the image, then curl at it. I wasn't sure how to manage this with tox. I looked into using tox-docker which does almost this, but it doesn't support passing args to the container. There were possible workarounds, but I didn't dig into it much

What needs to get done

  1. automate the integration tests from readme.md for all server images

Definition of Done

  1. server rocks have automated integration tests
@ca-scribner ca-scribner added the enhancement New feature or request label Mar 7, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5429.

This message was autogenerated

@ca-scribner
Copy link
Contributor Author

@orfeas-k also raised a good point that we could probably write the test purely in pytest. that might make it easier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant