Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The library doesn't seem to be complete #10

Closed
d2callpod opened this issue Jul 12, 2022 · 6 comments
Closed

The library doesn't seem to be complete #10

d2callpod opened this issue Jul 12, 2022 · 6 comments

Comments

@d2callpod
Copy link

There are quite a few things that are not in the library,
fun Modifier.introShowCaseTarget, fun rememberIntroShowCaseState, fun IntroShowCaseScaffold, etc.

I'm trying com.canopas.intro-showcase-view:introshowcaseview:1.0.5.

@Macksly
Copy link

Macksly commented Jul 14, 2022

I am experiencing this aswel, did you figure it out?

@d2callpod
Copy link
Author

I've copied this into my project.

https://github.com/canopas/Intro-showcase-view/blob/4a459a9baeca3480ede3d8b2cfe716ed4317d6ac/showcase/src/main/java/com/canopas/lib/showcase/IntroShowCase.kt

@cp-radhika-s
Copy link
Member

There are quite a few things that are not in the library, fun Modifier.introShowCaseTarget, fun rememberIntroShowCaseState, fun IntroShowCaseScaffold, etc.

I'm trying com.canopas.intro-showcase-view:introshowcaseview:1.0.5.

@d2callpod Thanks for reporting the issue.

Can you please try with

com.canopas.intro-showcase-view:introshowcaseview:1.0.7

@d2callpod
Copy link
Author

Looks like there has been some refactoring since the version I copy and pasted as well as the example app and blog post. The constructor takes a state rather than targets, now there is a scaffold... I don't have time to figure this out right now. I've moved onto another project.

@d2callpod
Copy link
Author

I've tried 1.0.7 and it works well. Thank you for the update.

Maybe this should be a separate issue but the circle is very big on tablets and phones in landscape.

Screenshot_20220819_190821-smaller

Screenshot_20220819_191535

Looks good on a phone in portrait.

Screenshot_20220819_1913442

@cp-radhika-s
Copy link
Member

cp-radhika-s commented Dec 29, 2022

I've tried 1.0.7 and it works well. Thank you for the update.
Maybe this should be a separate issue but the circle is very big on tablets and phones in landscape.

@d2callpod Thank for taking interest
can you please create new issue for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants