Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some useful features not found in the web bluetooth spec #5

Closed
ghost opened this issue Dec 18, 2020 · 10 comments
Closed

Some useful features not found in the web bluetooth spec #5

ghost opened this issue Dec 18, 2020 · 10 comments
Labels
enhancement New feature or request

Comments

@ghost
Copy link

ghost commented Dec 18, 2020

Is your feature request related to a problem? Please describe.
Some useful features found in other common bluetooth plugins/modules.

This plugin seems most promising for the future as it uses modern android (at least, can't speak for ios) features and seems relatively well designed. I might be wanting too much from it though.

  • reporting duplicate advertisements - boolean in scan filters to allow reporting the same device as many times as it advertises
  • scan timeout - ability to restrict the time spent scanning
  • bonding - but maybe i missed that when reading the spec

Anything else that might seem useful from: https://github.com/randdusing/cordova-plugin-bluetoothle

@pwespi
Copy link
Member

pwespi commented Dec 18, 2020

Thank you for your input. I will consider this when planning the next features.

Out of curiosity, what's your use case for "reporting duplicate advertisements"?

@ghost
Copy link
Author

ghost commented Dec 18, 2020

Sometimes I have 20+ BLE devices that I need data from (and quickly). and due to device connection limits I can't keep a constant connection to all of them. I instead send the the data in the advertisement packets. I haven't yet had a central device that can handle extended and periodic advertisements, so I can't do it the way I'd prefer.

@pwespi
Copy link
Member

pwespi commented Dec 28, 2020

  • requestLEScan (which allows you to get advertisement data)
  • stopLEScan
  • allowDuplicates
  • bonding -> Bonding #50

@pwespi pwespi added the enhancement New feature or request label Jan 7, 2021
@tellybrown
Copy link

tellybrown commented Jan 21, 2021

some sort of listener subscription to be notified when bluetooth is turned on/off to facilitate an event driven connect/disconnect of devices TIA

@BillBu
Copy link

BillBu commented Feb 12, 2021

Thanks for creating this plugin - very clean to use.
Registering for disconnect events as per @tellybrown's comment above would be a most welcome addition. Use case for me is when devices go out of range or are turned off.

@pwespi
Copy link
Member

pwespi commented Feb 13, 2021

@tellybrown @BillBu Thanks for your feedback. I just released v0.2.0 with the following features:

  • getEnabled
  • startEnabledNotifications
  • stopEnabledNotifications
  • optional onDisconnect callback for connect

I hope this will be useful.

@BillBu
Copy link

BillBu commented Feb 13, 2021

That's fantastic @pwespi thank you so much. I'll check it out this week.

@kegtron
Copy link

kegtron commented Feb 17, 2021

@tellybrown @BillBu Thanks for your feedback. I just released v0.2.0 with the following features:

Sounds like a great addition. Can you create a v0.2.0 release tag?

Thanks!

@pwespi
Copy link
Member

pwespi commented Feb 17, 2021

Sounds like a great addition. Can you create a v0.2.0 release tag?

Thanks!

Done. It was already published on npm, but I forgot to push the git tag. Thanks for letting me know.

@pwespi pwespi mentioned this issue Feb 26, 2021
@pwespi
Copy link
Member

pwespi commented Feb 26, 2021

Thank you for all your feedback.

I've created a new issue for bonding #50.

I think all the other points mentioned here have been addressed, so I'm closing this issue. If you have any other bugs or feature requests, feel free to open new issues.

@pwespi pwespi closed this as completed Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants