Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Defaults to carnival-core #92

Closed
3 tasks done
augustearth opened this issue May 11, 2022 · 0 comments
Closed
3 tasks done

Move Defaults to carnival-core #92

augustearth opened this issue May 11, 2022 · 0 comments

Comments

@augustearth
Copy link
Collaborator

augustearth commented May 11, 2022

Defaults, which is a de-facto configuration object, currently lives in carnival-util. It is used there only by MappedDataTable to get the cache directory so vines can write cache data. As part of #59, we want to move away from Defaults to explicit configuration objects. One step will be to elevate/isolate Defaults to carnival-core so it can be more easily transformed into a configuration object.

Looking at the code, it seems we are already mostly there. Defaults is used by MappedDataTable writeToFile, an implementation of the the method in MappedDataInterface. MappedDataInterface is legacy code.... we should be able to remove it. The new Vine functionality should not rely on it.

Steps

  • Remove MappedDataInterface
  • Remove implementation of MappedDataInterface in MappedDataTable
  • Move Defaults from carnival-util to carnival-core
augustearth added a commit that referenced this issue May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant