diff --git a/.github/workflows/benchmarks.yml b/.github/workflows/benchmarks.yml index 8d2ce7946b1..c246b98dad1 100644 --- a/.github/workflows/benchmarks.yml +++ b/.github/workflows/benchmarks.yml @@ -8,7 +8,7 @@ on: required: false type: boolean default: false - enableTBS: + enableTailSampling: description: 'Enable tail-based sampling on the APM server' required: false type: boolean @@ -57,7 +57,7 @@ jobs: TF_VAR_private_key: ./id_rsa_terraform TF_VAR_public_key: ./id_rsa_terraform.pub TF_VAR_run_standalone: ${{ inputs.runStandalone || github.event.schedule=='0 5 */5 * *' }} - TF_VAR_apm_server_tbs: ${{ inputs.enableTBS }} + TF_VAR_apm_server_tail_sampling: ${{ inputs.enableTailSampling }} RUN_STANDALONE: ${{ inputs.runStandalone || github.event.schedule=='0 5 */5 * *' }} TFVARS_SOURCE: ${{ inputs.profile || 'system-profiles/8GBx1zone.tfvars' }} # // Default to use an 8gb profile TF_VAR_BUILD_ID: ${{ github.run_id }} diff --git a/testing/benchmark/main.tf b/testing/benchmark/main.tf index 643973de3dd..04cc04644cd 100644 --- a/testing/benchmark/main.tf +++ b/testing/benchmark/main.tf @@ -103,7 +103,7 @@ module "ec_deployment" { drop_pipeline = var.drop_pipeline apm_server_expvar = true apm_server_pprof = true - apm_server_tbs = var.apm_server_tbs + apm_server_tail_sampling = var.apm_server_tail_sampling elasticsearch_size = var.elasticsearch_size elasticsearch_zone_count = var.elasticsearch_zone_count diff --git a/testing/benchmark/variables.tf b/testing/benchmark/variables.tf index 62f81fd9728..68bd461e1fb 100644 --- a/testing/benchmark/variables.tf +++ b/testing/benchmark/variables.tf @@ -92,7 +92,7 @@ variable "drop_pipeline" { type = bool } -variable "apm_server_tbs" { +variable "apm_server_tail_sampling" { default = false description = "Whether or not to enable APM Server tail-based sampling. Defaults to false" type = bool diff --git a/testing/infra/terraform/modules/ec_deployment/README.md b/testing/infra/terraform/modules/ec_deployment/README.md index 738545782fe..69596188ab0 100644 --- a/testing/infra/terraform/modules/ec_deployment/README.md +++ b/testing/infra/terraform/modules/ec_deployment/README.md @@ -47,7 +47,7 @@ used to configure the module, please refer to the [EC Provider docs](https://reg | [apm\_server\_expvar](#input\_apm\_server\_expvar) | Whether or not to enable APM Server's expvar endpoint. Defaults to false | `bool` | `false` | no | | [apm\_server\_pprof](#input\_apm\_server\_pprof) | Whether or not to enable APM Server's pprof endpoint. Defaults to false | `bool` | `false` | no | | [apm\_server\_size](#input\_apm\_server\_size) | Optional apm server instance size | `string` | `"1g"` | no | -| [apm\_server\_tbs](#input\_apm\_server\_tbs) | Whether or not to enable APM Server tail-based sampling. Defaults to false | `bool` | `false` | no | +| [apm\_server\_tbs](#input\_apm\_server\_tbs) | Whether or not to enable APM Server tail-based sampling. Defaults to false | `bool` | `false` | no | | [apm\_server\_zone\_count](#input\_apm\_server\_zone\_count) | Optional apm server zone count | `number` | `1` | no | | [custom\_apm\_integration\_pkg\_path](#input\_custom\_apm\_integration\_pkg\_path) | Path to the zipped custom APM integration package, if empty custom apm integration pkg is not installed | `string` | `""` | no | | [deployment\_name\_prefix](#input\_deployment\_name\_prefix) | Optional ESS or ECE region. Defaults to GCP US West 2 (Los Angeles) | `string` | `"apmserver"` | no | diff --git a/testing/infra/terraform/modules/ec_deployment/deployment.tf b/testing/infra/terraform/modules/ec_deployment/deployment.tf index 13c21319948..fc1c8bd9855 100644 --- a/testing/infra/terraform/modules/ec_deployment/deployment.tf +++ b/testing/infra/terraform/modules/ec_deployment/deployment.tf @@ -119,7 +119,7 @@ resource "local_file" "enable_features" { elastic_password = ec_deployment.deployment.elasticsearch_password, enable_expvar = var.apm_server_expvar enable_pprof = var.apm_server_pprof - enable_tbs = var.apm_server_tbs + enable_tail_sampling = var.apm_server_tail_sampling }) filename = "${path.module}/scripts/enable_features.sh" } diff --git a/testing/infra/terraform/modules/ec_deployment/scripts/enable_features.tftpl b/testing/infra/terraform/modules/ec_deployment/scripts/enable_features.tftpl index 8db91031972..83d73110465 100644 --- a/testing/infra/terraform/modules/ec_deployment/scripts/enable_features.tftpl +++ b/testing/infra/terraform/modules/ec_deployment/scripts/enable_features.tftpl @@ -17,7 +17,7 @@ fi # Abort early if features are already set as desired echo $${POLICY} | jq -e '.item | select(.inputs[].policy_template == "apmserver").inputs[].vars.expvar_enabled.value == ${enable_expvar}' && echo $${POLICY} | jq -e '.item | select(.inputs[].policy_template == "apmserver").inputs[].vars.pprof_enabled.value == ${enable_pprof}' && - echo $${POLICY} | jq -e '.item | select(.inputs[].policy_template == "apmserver").inputs[].vars.tail_sampling_enabled.value == ${enable_tbs}' && + echo $${POLICY} | jq -e '.item | select(.inputs[].policy_template == "apmserver").inputs[].vars.tail_sampling_enabled.value == ${enable_tail_sampling}' && echo "Features already set as desired" && exit 0 # Download and modify the APM policy @@ -27,7 +27,7 @@ echo $${POLICY} | jq '.item' | \ jq 'select(.inputs[].policy_template == "apmserver").inputs[].vars.expvar_enabled = {type: "bool", value: ${enable_expvar}}' |\ jq 'select(.inputs[].policy_template == "apmserver").inputs[].vars.pprof_enabled = {type: "bool", value: ${enable_pprof}}' |\ jq 'select(.inputs[].policy_template == "apmserver").inputs[].vars.tail_sampling_storage_limit = {"value":"10GB","type":"text"}' |\ # set TBS storage limit to 10GB by default - jq 'select(.inputs[].policy_template == "apmserver").inputs[].vars.tail_sampling_enabled = {type: "bool", value: ${enable_tbs}}' > policy.json + jq 'select(.inputs[].policy_template == "apmserver").inputs[].vars.tail_sampling_enabled = {type: "bool", value: ${enable_tail_sampling}}' > policy.json # Update the policy curl -s -H 'content-type: application/json' -H 'kbn-xsrf: true' -X PUT -k -d@policy.json -u $${KIBANA_AUTH} $${KIBANA_ENDPOINT} diff --git a/testing/infra/terraform/modules/ec_deployment/variables.tf b/testing/infra/terraform/modules/ec_deployment/variables.tf index aa5695a5754..817bc063377 100644 --- a/testing/infra/terraform/modules/ec_deployment/variables.tf +++ b/testing/infra/terraform/modules/ec_deployment/variables.tf @@ -122,7 +122,7 @@ variable "apm_server_pprof" { type = bool } -variable "apm_server_tbs" { +variable "apm_server_tail_sampling" { default = false description = "Whether or not to enable APM Server tail-based sampling. Defaults to false" type = bool