Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ledger Clear Signing Initiative #159

Open
2 tasks
brunomenezes opened this issue Aug 11, 2024 · 0 comments
Open
2 tasks

Ledger Clear Signing Initiative #159

brunomenezes opened this issue Aug 11, 2024 · 0 comments
Assignees
Labels
experiment Meant for exploration and discovery. The end result may or may not come to fruition. type:feature new feature or improvement over an existing feature

Comments

@brunomenezes
Copy link
Collaborator

📄 Context

Currently, when interacting with Pool methods, users must use the "blind signing" active on ledger devices to proceed. You would activate the blind sign, read the warning once, and continue your business. Ledger recently changed its communication strategy, showing that message on every interaction and having the Clear Signing Initiative. I am linking the post below, but it needs some collaboration from the ecosystem for that to work properly. We use web3-onboarding with wallet-connect when interacting with the ledger.

Post Link: https://www.ledger.com/blog-ledgers-clear-signing-initiative-paving-the-way-for-safer-transactions

A point from the post

— Achieving widespread adoption of Clear Signing necessitates collaboration across the digital asset ecosystem, thus, Ledger is actively engaging with industry leaders, blockchain developers, and partners committed to this initiative

PS: The ledger can show information in a human-readable format when defining an allowance and calling the approve method, but not when receiving any transaction/action related to the pool contract, e.g., deposit, stake, etc. Not sure if that is because the Approve is from a standard ERC-20 contract, and it can "get" the ABI, I am not sure about their implementation, but is just odd because All mainnet StakingPoolImpl contracts are verified (We can check read/write methods on Etherscan)

✔️ Solution

Keep track of that initiative and check for possible changes and/or updates necessary to web3-onboarding core + packages to be compliant with it. The solution is dependent on third parties in the ecosystem.

📈 Subtasks

  • Check on initiative and update procedures once it is available.

🎯 Definition of Done

  • Pool actions can be read properly and blind signing is not necessary.
@brunomenezes brunomenezes added type:feature new feature or improvement over an existing feature experiment Meant for exploration and discovery. The end result may or may not come to fruition. labels Aug 11, 2024
@brunomenezes brunomenezes self-assigned this Aug 11, 2024
@github-project-automation github-project-automation bot moved this to 📌 Todo in Explorer Unit Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experiment Meant for exploration and discovery. The end result may or may not come to fruition. type:feature new feature or improvement over an existing feature
Projects
Status: 📌 Todo
Development

No branches or pull requests

1 participant