Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sanity check for claims #293

Open
7 tasks
guidanoli opened this issue Jul 3, 2024 · 1 comment
Open
7 tasks

Add sanity check for claims #293

guidanoli opened this issue Jul 3, 2024 · 1 comment
Labels
A-contracts Area: contracts T-feature Type: feature

Comments

@guidanoli
Copy link
Collaborator

guidanoli commented Jul 3, 2024

📚 Context

With the full Output Unification, all outputs will live under the same tree. Claims will then function as checkpoints, for the array of outputs will only grow, but old proofs will still be usable. On-chain, however, no introspection is made on the claim itself, certifying that the previous claims proves only a prefix of the outputs proven by the next claim.

✔️ Solution

We can add a sanity check on the claim submission entry point, ensuring that each output proven by the previous claim can still be proven by the new claim. This proof has $O(log\ n)$ size, with $n$ being the number of outputs, and uses $O(log\ N)$ gas to verify, with $N$ being the maximum number of outputs.

📈 Subtasks

  • Specify the check procedure
  • Define a ClaimValidityProof structure
  • Implement a LibClaimValidityProof library
  • Add unit tests for the library
  • Adjust the IConsensus interface
  • Adjust the IConsensus implementations
  • Add unit tests for the IConsensus implementations
@guidanoli guidanoli added T-feature Type: feature A-contracts Area: contracts labels Jul 3, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Rollups Unit Jul 3, 2024
@guidanoli
Copy link
Collaborator Author

This feature is planned for after the v2 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-contracts Area: contracts T-feature Type: feature
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant