Move VoucherExecution component under packages/ui

[nevendyulgerov]

📄 Context

As per this comment move the VoucherExecution component under packages/ui.

📈 Subtasks

• VoucherExecution is moved to packages/ui
• Test suite for VoucherExecution is moved to packages/ui

🎯 Definition of Done

• Executing a voucher works ok
• Tests for voucher execution are passing

[brunomenezes]

Hi @nevendyulgerov, my comment was to discuss the motivation behind the current choice rather than move it directly.
For example, a few questions on that end;

• What was the motivation to add to the apps/web instead of the packages/ui?
• Is that because of the types generated by our codegen tools? (Generators are good if you accept that sometimes some work will be needed on rough edges).
• Is that related to extensibility?

[nevendyulgerov]

@brunomenezes , the motivation was the types coming from the codegen located in apps/web.

In VoucherExecution we are using a prop voucher with interface Voucher coming from graphql/rollups/types. Initially, my plan was to place this component under packages/ui, however due to this type already existing in apps/web I decided to keep it there to prevent interface duplication.

[nevendyulgerov]

I think we can close this one for the time being.