Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ether Deposit - add validation on change and display balance #293

Closed
7 tasks done
brunomenezes opened this issue Jan 7, 2025 · 0 comments · Fixed by #294
Closed
7 tasks done

Ether Deposit - add validation on change and display balance #293

brunomenezes opened this issue Jan 7, 2025 · 0 comments · Fixed by #294
Assignees
Labels
Type: Feature Add a new feature to the system

Comments

@brunomenezes
Copy link
Collaborator

brunomenezes commented Jan 7, 2025

📄 Context

The Ether deposit form is quite simple, but it lacks helpful information for those who use it. e.g. Quick feedback on error messages and display the current balance of the connected account.

✔️ Solution

Apply validation as the amount changes for quick feedback. Also, include the current formatted balance with the possibility to click the max button.

📈 Subtasks

  • Change the logic to apply validation on change.
  • Add the balance information below the amount input, including a max action to auto-fill the input.
  • Add test cases.

🎯 Definition of Done

  • I can see error messages as I type the amount and the validation fails.
  • I can see the current balance of my connected account.
  • CI builds are passing.
  • Vercel builds are complete.
@brunomenezes brunomenezes added the Type: Feature Add a new feature to the system label Jan 7, 2025
@brunomenezes brunomenezes self-assigned this Jan 7, 2025
@github-project-automation github-project-automation bot moved this to 📌 Todo in Explorer Unit Jan 7, 2025
@brunomenezes brunomenezes moved this from 📌 Todo to 🧑‍💻 In Progress in Explorer Unit Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Add a new feature to the system
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant