-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve components structure in the web app #83
Comments
Hey @brunomenezes , @tuler , please let me know if you agree for this to be implemented. |
I usually prefer a separation using the semantics of the component instead of the element type. “Layout” is the semantics. |
I would use feature-based for better grouping. For example, |
I'm ok with using feature-based grouping and having the base components directly inside |
📄 Context
Currently,
components
folder in the web app contains a flat list of components. The only way to add new components is vertically, by creating another file directly insidecomponents
folder.As the application grows, if we continue to use this structure, we'll end up with a large vertical list of components. So, to prevent this, we'd like to have the ability to expand that folder vertically as well as horizontally to allow for better organisation of components via groups.
This means that we'd need to change the structure of
components
folder and introduce subfolders that would contain individual components. Suggested structure is:✔️ Solution
Implement the above described folder structure for
components
folder.🎯 Definition of Done
components
folder contains subfolders (groups) instead of a flat vertical structure.The text was updated successfully, but these errors were encountered: