Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Node Services' configuration generation #309

Closed
Tracked by #301
fmoura opened this issue Feb 5, 2024 · 1 comment
Closed
Tracked by #301

Improve Node Services' configuration generation #309

fmoura opened this issue Feb 5, 2024 · 1 comment
Assignees
@fmoura
Labels
#feat:tests Feature: tests
Milestone
1.4.0

Comments

@fmoura
Copy link
Contributor

fmoura commented Feb 5, 2024

📚 Context

The Node configuration generation as of today generates specific public methods for each variable, and these methods get them from System Environment. It makes it difficult to configure the services

✔️ Solution

Instead of generating specific methods, generate a Configuration Structure with all the variables. This way the Tests are able to construct the same structure with custom values.
@fmoura fmoura self-assigned this Feb 5, 2024
@fmoura fmoura added this to Node Unit Feb 5, 2024
@fmoura fmoura moved this to 🏗 In progress in Node Unit Feb 6, 2024
@fmoura fmoura mentioned this issue Feb 6, 2024
Closed
3 tasks
@gligneul gligneul added this to the 1.3.0 milestone Feb 8, 2024
@gligneul gligneul added the #feat:tests Feature: tests label Feb 8, 2024
@gligneul gligneul modified the milestones: 1.3.0, 1.4.0 Feb 9, 2024
@fmoura fmoura linked a pull request Feb 9, 2024 that will close this issue
feat: Improve config generation #318
Closed
@fmoura fmoura mentioned this issue Feb 15, 2024
Closed
@torives torives mentioned this issue Feb 20, 2024
Closed
@gligneul gligneul moved this from 🏗 In progress to 👀 In review in Node Unit Feb 27, 2024
@gligneul
Copy link
Contributor

This will be replaced by #325

@gligneul gligneul moved this from 👀 In review to ✅ Done in Node Unit Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fmoura fmoura

Labels
#feat:tests Feature: tests
Projects
Node Unit
Archived in project
Milestone
1.4.0
Development

Successfully merging a pull request may close this issue.

feat: Improve config generation cartesi/rollups-node
2 participants
@fmoura @gligneul