From f19b5fd6d07c22ac938b794a32699f306fbb583d Mon Sep 17 00:00:00 2001 From: Zilvinas Urbonas Date: Wed, 7 Apr 2021 21:27:46 +0300 Subject: [PATCH] fix: handle missing CSINodes list gracefully --- internal/services/collector/collector.go | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/internal/services/collector/collector.go b/internal/services/collector/collector.go index a55c461b..5c5e4669 100644 --- a/internal/services/collector/collector.go +++ b/internal/services/collector/collector.go @@ -3,6 +3,7 @@ package collector import ( "context" + "github.com/sirupsen/logrus" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" "k8s.io/client-go/kubernetes" @@ -36,10 +37,6 @@ func (c *collector) Collect(ctx context.Context) (*ClusterData, error) { return nil, err } - if err := c.collectPods(ctx); err != nil { - return nil, err - } - if err := c.collectPersistentVolumes(ctx); err != nil { return nil, err } @@ -72,8 +69,11 @@ func (c *collector) Collect(ctx context.Context) (*ClusterData, error) { return nil, err } + if err := c.collectCSINodeList(ctx); err != nil { - return nil, err + // https://kubernetes-csi.github.io/docs/csi-node-object.html + // GA since 1.17 + c.log.Debugf("could not get CSINodes: %v", err) } if err := c.collectStorageClassList(ctx); err != nil {