Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working on Mac for me. #16

Open
crush-157 opened this issue Jun 21, 2019 · 12 comments
Open

Not working on Mac for me. #16

crush-157 opened this issue Jun 21, 2019 · 12 comments

Comments

@crush-157
Copy link

I'm using a Mac (Mojave 10.14.5)

I have installed ruby-solargraph0.4.0 in Atom

I have installed the solargraph gem (0.33.2)

I have restarted Atom.

I start typing in a Ruby file and nothing happens. The keystroke suggested for a manual search is ctrl+space, but that doesn't work on a mac and command+space just opens spotlight search.

I also tried using the online demo (solargraph.org/demo), this time from my Chromebook and I don't get any code completion there either.

Any suggestions for getting ruby-solargraph working for Atom on the Mac?

@rpf13
Copy link

rpf13 commented Oct 9, 2019

I have the exact same issue, can't bring solargaph to work with atom. VSCode works fine...

@svoop
Copy link

svoop commented Oct 19, 2019

The current versions (ruby-solargraph 0.6.1 and solargraph 0.37.2) work just fine on my Mac with Ruby 2.6.5 installed from source with ruby-install and managed by chruby.

You might want to check the settings of the ruby-solargraph package in Atom and make sure, the path to the solargraph binary is correct.

I use the following to update this setting on the CLI after every Ruby upgrade:

sed -i "" "s|commandPath: \".*/solargraph\"|commandPath: \"${HOME}/.gem/ruby/$(ruby -e 'puts RUBY_VERSION')/bin/solargraph\"|" ~/.atom/config.cson

As an alternative, just edit this setting in Atom yourself. To figure out the solargraph binary path to use:

echo "${HOME}/.gem/ruby/$(ruby -e 'puts RUBY_VERSION')/bin/solargraph"

⚠️ Bear in mind that the use of RVM will complicate things and the above most likely won't work. I've dumped RVM a long while ago in favor of chruby which doesn't isolate gemsets – we have Bundler for that now.

@dedman
Copy link

dedman commented Jan 28, 2020

I just installed on Mac too, and have checked all the obvious things and still doesn't seem to work. Did you guys get it working eventually?

@msharma-boop
Copy link

Same issue for me. I've followed all the above steps and still couldn't able to figure out the solution

@crush-157
Copy link
Author

crush-157 commented Sep 4, 2020

Revisiting this.

Today I tried again.

Note I use ruby-install and chruby not RVM as per @svoop's comments above.

MacOS Mojave 10.14.6
Ruby 2.7.1
Atom 1.50.0

I installed solargraph gem
Checked it runs as a shell command
Used which solargraph to get the path
Opened Atom
Installed ruby-solargraph package 0.6.1
Updated command path to point to the solargraph command
Restarted atom
Opened a ruby source file

And nothing happens. I type variable-name.<space / tab / first-letter-of-method> => nothing.

@svoop - what combination of keystrokes (on a Mac) do you use to trigger autocomplete?

Can you see anything missing from the steps above?

@crush-157
Copy link
Author

@castwide any comment?

@castwide
Copy link
Owner

castwide commented Sep 5, 2020

@crush-157 The extension is only confirmed to work with rvm and rbenv, so chruby might pose a problem. I'll test on a MacBook and see what I can figure out. If anyone has had success with MacOS and chruby, please let us know.

@svoop
Copy link

svoop commented Sep 6, 2020

@castwide @crush-157 I got it to work on a Mac with chruby as follows:

Install the atom-solagraph package, then create a wrapper for the binary as /opt/bin/solargraph:

#!/bin/bash
$(gem env gemdir)/bin/solargraph "$@"

Make sure the wrapper is executable:

chmod a+x /opt/bin/solargraph

Then edit the path to the binary in ~/.atom/config.cson to read:

"ruby-solargraph":
  commandPath: "/opt/bin/solargraph"

Finally, make sure the solargraph gem is installed on all Ruby versions you're using with chruby.

Don't forget to restart Atom to make sure it picks up the changes. At least my Atom didn't without a restart.

@msharma-boop
Copy link

@castwide I tried setting up solargraph as per instruction on Mac and

ruby **ruby 2.7.1p83 (2020-03-31 revision a0c7c23c9c) [x86_64-darwin19]
**
solargraph : 0.39.15
and reset the command path too. Stil not working for me
please assist

@crush-157
Copy link
Author

@svoop I have tried doing as you said and it made no difference.

Question: what keystrokes are you using, if any, on a mac, to start code completion?

@svoop
Copy link

svoop commented Sep 7, 2020

@crush-157 I'm kinda peculiar with keystrokes and configured all kind of search and autocomplete stuff on combinations of ctrl, alt, cmd and space. For solargraph, I've assigned cmd-space which usually opens Spotlight. (I don't use Spotlight very often and therefore disabled cmd-space systemwide in sysprefs, so no collision there.)

@crush-157
Copy link
Author

@svoop sadly I use spotlight all the time!

Another thing I'm curious about is why the wrapper? I followed your directions in a cargo - cult fashion just to see if it helped but it didn't.

I wasn't that surprised, since solargraph was running just fine from the command prompt as soon as I installed the gem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants