From d31c74babee3eb938d2267fb058b23d076d6e43c Mon Sep 17 00:00:00 2001 From: Josh Stein <46639943+jcstein@users.noreply.github.com> Date: Thu, 17 Oct 2024 18:13:34 -0400 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Rootul P --- cips/cip-pfb-limits.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/cips/cip-pfb-limits.md b/cips/cip-pfb-limits.md index e390e16..ab387a9 100644 --- a/cips/cip-pfb-limits.md +++ b/cips/cip-pfb-limits.md @@ -11,7 +11,7 @@ ## Abstract -This CIP proposes to set limits for the number of PayForBlobs (PFBs) messages and non-PFBs messages per block. The proposal is to set the limits to 600 PFBs messages and 200 non-PFBs messages per block. Setting PFB and non-PFBs limits is not consensus-breaking. +This CIP proposes to set limits for the number of PayForBlobs (PFBs) messages and non-PFBs messages per block. The proposal is to set the limits to 600 PFBs messages and 200 non-PFB messages per block. Setting PFB and non-PFBs limits is not consensus-breaking. ## Specification @@ -21,12 +21,12 @@ This CIP proposes to set limits for the number of PayForBlobs (PFBs) messages an ## Rationale -The rationale for this proposal is to prevent long block times on the network by limiting the number of PFBs and non-PFBs messages per block. This was initially not considered consensus-breaking, but it has a meaningful effect on users and should be formalized in a CIP. +The rationale for this proposal is to prevent long block times on the network by limiting the number of PFBs and non-PFB messages per block. This is not consensus-breaking but it has a meaningful effect on users and should be formalized in a CIP. 1. The limits for PFBs (Pay for Blob transactions) and non-PFBs per block were established using the following process: 1. Benchmarks were conducted in [PR 3904 on celestia-app](https://github.com/celestiaorg/celestia-app/pull/3904) to measure ABCI method processing times for different transaction types. 1. A target processing time of ~0.25 seconds was set to prevent long block times. - 1. Based on these benchmarks, run on the recommended validator configuration (4 CPU, 16GB RAM), a soft limiter was implemented in the prepare proposal stage. + 1. Based on these benchmarks run on the recommended validator configuration (4 CPU, 16GB RAM), a soft limiter was implemented in the prepare proposal stage. 1. This limiter sets specific caps on the number of PFB and non-PFB messages allowed in a default block to meet the processing time target. 1. While default blocks adhere to these limits, blocks exceeding them can still be included if they reach consensus, ensuring flexibility. 1. This approach balances network efficiency with block processing speed, directly informing the PFB and non-PFB limits now in place.