feat(p2p/dht): Enable DHT server metrics #4071
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crStiv
requested review from
renaynay,
Wondertan,
vgonkivs,
walldiss and
cristaloleg
as code owners
|
Hey @crStiv! Thank you for taking this one! I see that you made wrappers and implemented metrics manually. Could you please consider using metrics that are already implemented inside libp2p/kad-dht pkg? You would need to plug them to our metrics collector |
Hi Vlad, I've updated dht.go, does it seem good for you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR implements DHT server metrics to track server load and performance. Added metrics include:
Key metrics:
All metrics are available via Prometheus endpoint with
celestia_dht_prefix and include network/node_type labels.Closes #4066