From b0b5516a9d1597a7f8e3bd41918800dbf336e9b9 Mon Sep 17 00:00:00 2001
From: Christian Sahlmann <christian.sahlmann@telekom.de>
Date: Thu, 4 Jan 2024 17:06:33 +0100
Subject: [PATCH] validate that `to` url contains a hostname

---
 mb_netmgmt/__init__.py  |  2 +-
 mb_netmgmt/__main__.py  |  9 ++++++++-
 test/test_mb_netmgmt.py | 11 +++++++++--
 3 files changed, 18 insertions(+), 4 deletions(-)

diff --git a/mb_netmgmt/__init__.py b/mb_netmgmt/__init__.py
index 25f0d29..70a2ded 100644
--- a/mb_netmgmt/__init__.py
+++ b/mb_netmgmt/__init__.py
@@ -18,7 +18,7 @@
 # along with mb-netmgmt. If not, see <https://www.gnu.org/licenses/
 
 """Network Management Protocols for Mountebank"""
-__version__ = "0.0.77"
+__version__ = "0.0.78"
 
 import os
 import subprocess
diff --git a/mb_netmgmt/__main__.py b/mb_netmgmt/__main__.py
index 227e9d3..5dabf7a 100755
--- a/mb_netmgmt/__main__.py
+++ b/mb_netmgmt/__main__.py
@@ -107,7 +107,7 @@ def get_to(self):
             if proxy:
                 self.save_key(proxy)
                 disable_algorithms(proxy.get("disabled_algorithms", {}))
-                return urlparse(proxy["to"])
+                return parse_to(proxy["to"])
         except (IndexError, AttributeError):
             pass
 
@@ -124,6 +124,13 @@ def get_proxy(self, stub):
         return stub["responses"][0].get("proxy")
 
 
+def parse_to(url: str):
+    to = urlparse(url)
+    if not to.hostname:
+        raise ValueError("No hostname")
+    return to
+
+
 def get_cli_patterns():
     patterns = []
     patterns.append(
diff --git a/test/test_mb_netmgmt.py b/test/test_mb_netmgmt.py
index dd4a574..8623fde 100644
--- a/test/test_mb_netmgmt.py
+++ b/test/test_mb_netmgmt.py
@@ -7,12 +7,12 @@
 import ncclient.manager
 import paramiko
 import pytest
-from ncclient.transport.session import BASE_NS_1_0, MSG_DELIM, to_ele
 from ncclient.devices.default import DefaultDeviceHandler
+from ncclient.transport.session import BASE_NS_1_0, MSG_DELIM, to_ele
 from scapy.layers.snmp import ASN1_NULL, SNMPvarbind
 
 from mb_netmgmt import mb, netconf, snmp, ssh, use_scalar_strings, yaml
-from mb_netmgmt.__main__ import create_server, get_cli_patterns
+from mb_netmgmt.__main__ import create_server, get_cli_patterns, parse_to
 
 port = 8081
 prompt = b"prompt#"
@@ -280,3 +280,10 @@ def test_to_varbind_no_such_instance():
     assert result == SNMPvarbind(
         oid="1.3", value=None, noSuchObject=None, noSuchInstance=0, endOfMibView=None
     )
+
+
+def test_parse_to():
+    assert parse_to("telnet://localhost").hostname == "localhost"
+    assert parse_to("telnet://localhost:23").port == 23
+    with pytest.raises(ValueError):
+        parse_to("localhost")