Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Allow to set identity for the pool account #1678

Open
mustermeiszer opened this issue Jan 8, 2024 · 0 comments
Open

Feat: Allow to set identity for the pool account #1678

mustermeiszer opened this issue Jan 8, 2024 · 0 comments
Labels
I3-annoyance The code behaves as expected, but "expected" is an issue. I6-refactoring Code needs refactoring. P2-nice-to-have Issue is worth doing.

Comments

@mustermeiszer
Copy link
Collaborator

Description

We want to be able to allow a PoolAdmin to create an identity for the main pool account that we are deriving from the pool id. See old ticket here.

The problem is that pallet-identity does not provide interaction with it, besides using the extrinsic interface. As this interface expects a RuntimeOrigin::signed(AccountId) and places looks on the account for deposits we have to create a wrapper call as the derived account can not sign.

Steps

  • Create a set_pool_identity() extrinsic in the pallet-pool-registry
    • Only callable by PoolAdmin
  • Interface should allow to call
     pub fn set_identity(
       origin: OriginFor<T>,
       info: Box<IdentityInfo<T::MaxAdditionalFields>>,
    ) -> DispatchResultWithPostInfo {
    afterwards.
  • Use Origin::signed(PoolAccount) as the origin for the call
  • Move deposit from pool-admin account to PoolAccount beforehand

Research/based on

Issuers needs to display the accounts nicely on subscan et. al.

How will this affect the code base

Enhance usability for issuers.

What are foreseen obstacles or hurdles to overcome?

  • Chaning identities not yet thought about
@wischli wischli added this to the Centrifuge 1026 milestone Jan 8, 2024
@wischli wischli added I3-annoyance The code behaves as expected, but "expected" is an issue. I6-refactoring Code needs refactoring. P5-soon Issue should be addressed soon. labels Jan 8, 2024
@wischli wischli added P2-nice-to-have Issue is worth doing. and removed P5-soon Issue should be addressed soon. labels Apr 9, 2024
@mustermeiszer mustermeiszer changed the title feat: Allow to set identity for the pool account Feat: Allow to set identity for the pool account Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I3-annoyance The code behaves as expected, but "expected" is an issue. I6-refactoring Code needs refactoring. P2-nice-to-have Issue is worth doing.
Projects
None yet
Development

No branches or pull requests

2 participants