Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artifacts are not deleted when removed from the case body text #104

Open
vacmf opened this issue May 24, 2016 · 1 comment
Open

Artifacts are not deleted when removed from the case body text #104

vacmf opened this issue May 24, 2016 · 1 comment

Comments

@vacmf
Copy link
Contributor

vacmf commented May 24, 2016

Currently artifacts are parsed each time an event content change.
If there are new artifacts they are added, but if the new content contains less artifacts than before, those no longer present are not removed from the artifacts list.

In my opinion when an event is modified and contains less artifacts then before, those no longer included should be removed to reflect the new content.

I know you can do it manually but it's too error prone and time consuming when the chance includes tens or hundreds of artifacts to remove.

@tomchop
Copy link
Contributor

tomchop commented Jun 1, 2016

We had tried similar stuff and ended up with some performance issues (parsing the WHOLE incident content every time a comment is saved can be time-consuming, especially when there are several of comments that have to be individually queried from the database).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants