Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return value of get_entities_by_keys should always be a list #36

Open
joente opened this issue Nov 24, 2021 · 0 comments
Open

Return value of get_entities_by_keys should always be a list #36

joente opened this issue Nov 24, 2021 · 0 comments
Assignees
@joente
Labels
enhancement

Comments

@joente
Copy link
Member

joente commented Nov 24, 2021 •
edited
Loading

Currently, the function get_entities_by_keys returns None when no entities are found.

It makes much more sense to always return a list, and just an empty list if no entities are found.
@joente joente self-assigned this Nov 24, 2021
@joente joente changed the title Return value of get_entities_by_keys should alway be a list Return value of get_entities_by_keys should always be a list Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joente joente

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joente