From 522807dd55238e81a4363dbca6b9634b632f712d Mon Sep 17 00:00:00 2001
From: jaredb96 <goldpineresin124@gmail.com>
Date: Thu, 27 Jun 2024 16:39:27 -0400
Subject: [PATCH] Fix V631 validator.

---
 hmda/src/main/scala/hmda/validation/dsl/PredicateCommon.scala  | 3 +++
 .../hmda/validation/rules/lar/validity/common/V631_1.scala     | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/hmda/src/main/scala/hmda/validation/dsl/PredicateCommon.scala b/hmda/src/main/scala/hmda/validation/dsl/PredicateCommon.scala
index 53ce9827ae..14e3cbcd67 100644
--- a/hmda/src/main/scala/hmda/validation/dsl/PredicateCommon.scala
+++ b/hmda/src/main/scala/hmda/validation/dsl/PredicateCommon.scala
@@ -1,5 +1,7 @@
 package hmda.validation.dsl
 
+import hmda.model.filing.lar.enums.EthnicityEnum
+
 import scala.util.Try
 
 object PredicateCommon {
@@ -64,6 +66,7 @@ object PredicateCommon {
 
   def empty[A]: Predicate[A] = (_: A) match {
     case s: String => s.isEmpty
+    case s: EthnicityEnum => s.code == 0
     case _ =>
       throw new NotImplementedError("'empty doesn't handle non-string values yet'")
   }
diff --git a/hmda/src/main/scala/hmda/validation/rules/lar/validity/common/V631_1.scala b/hmda/src/main/scala/hmda/validation/rules/lar/validity/common/V631_1.scala
index d9b7f1764a..7aef483658 100644
--- a/hmda/src/main/scala/hmda/validation/rules/lar/validity/common/V631_1.scala
+++ b/hmda/src/main/scala/hmda/validation/rules/lar/validity/common/V631_1.scala
@@ -25,7 +25,7 @@ object V631_1 extends EditCheck[LoanApplicationRegister] {
   )
 
   override def apply(lar: LoanApplicationRegister): ValidationResult =
-    if(lar.coApplicant.ethnicity.otherHispanicOrLatino == "") {
+    if(lar.coApplicant.ethnicity.otherHispanicOrLatino.isEmpty) {
       lar.coApplicant.ethnicity.ethnicity1 is containedIn(validEthnicities) and (lar.coApplicant.ethnicity.ethnicity1 not empty)
     }
     else {