-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to configure button icon #19
Labels
Comments
@zubairslamdien Can you take this one on since you're working on #12 ? Thanks! |
That should be fine @swashbuck. I'll try to get to it in the week. |
guywillis
added a commit
that referenced
this issue
Jan 17, 2025
🎉 This issue has been resolved in version 1.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Subject of the enhancement
Currently, the button icon is baked into the less. It would be good to have this as a configurable option named
_iconClass
.The icon class would appear on the
.icon
element, which also makes it easier when we need to globally replace certain icon types. For example:While we are making this change, the
.icon
element should align to other implementations (ex. use aspan
tag instead of adiv
).The text was updated successfully, but these errors were encountered: