Breakpoints docs are confusing or incorrect? #2839
adbutterfield
started this conversation in
General
Replies: 1 comment 1 reply
-
Thinking about it more... |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I was looking at the docs here: https://panda-css.com/docs/customization/theme#breakpoints
One of my engineers set the breakpoints in our preset with
sm: 0px
because in the docs it says each breakpoint is set with a media query usingmin-width
. We ended up not having any small size styles...Since the responsiveness is handled mobile first, there isn't any media query for small actually. The
sm
value - 1 is the effectivemax-width
.Seems like it would be nice to do one of the following:
max-width
for each breakpoint (breaking change).sm
, and onlymd
and up, and set the value provided to themin-width
of the media query for that breakpoint (breaking change).I kind of like the last option the best, because it's mobile first and a small media query isn't necessary with the
min-width
approach.Or maybe I'm the only one who finds this confusing?
Beta Was this translation helpful? Give feedback.
All reactions