fix: Advertised names are not showing

[jefflongo]

Description

Advertised names are empty strings.

Steps To Reproduce

1. Scan for devices
2. Observe name is empty string

Expected Behavior

Expected to see non-empty name. Works on other platforms, and Windows itself can see the peripheral name.

Screenshots

N/A

Additional Context

I believe this to be a problem in WinBLE, since WinBLE is reporting the name as an empty string.

[chan150]

Hi @jefflongo
It seem to be WinBLE-side problem as you guess.
I check WinBLE library to fix issues if i can.

[jefflongo]

I've dug into this issue a bit, and have determined the issue. WinBLE receives two types of scan results:

1. advType = 'ScanResponse': this result contains the name but not the advertised services.
2. advType = 'ConnectableUndirected': this result contains advertised services but not the name.

Full documentation on the advTypes here.

So I don't think it's possible to fully construct the BluetoothDeviceWindows (or at least capture both the name and advertisement data) in the scan result stream. Or perhaps the addOrUpdate can fill in the missing data when it comes, instead of replacing the entire object.

Separately, FBP Windows needs an advName getter. It can just be redirected to platformName since they are the same.