New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI/CD -- Basic status check as part of PR, require pass to merge #178

Open

vincent-czi opened this issue Aug 24, 2022 · 0 comments

Assignees

Labels

[theme] eng excellence [type] Launch detritus

Milestone

Launch cleanup & ...

Collaborator

vincent-czi commented Aug 24, 2022 •

edited

Loading

Would be valuable to have some kind of status check in GitHub Actions for every PR that verifies some basic things before allowing a PR to be merged:

Linting
Formatting
TypeScript not throwing errors
Tests? (This is a can of worms depending on how deep you want testing to go, but we could try to implement a smoke test as a very first test, put that into this job. Although might be better to split that off into its own issue to ensure this ticket gets done in a timely fashion.)

vincent-czi self-assigned this

vincent-czi added this to the Stable beta launch milestone

sidneymbell moved this to In Progress in Galago roadmap

sidneymbell removed the status in Galago roadmap

sidneymbell modified the milestones: Stable beta launch, Launch cleanup & eng excellence

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment