From e560000c536f8ae9838f7c47d2db4ba4e3c6fc9a Mon Sep 17 00:00:00 2001 From: Nina Bernick Date: Thu, 1 Aug 2024 09:42:53 -0700 Subject: [PATCH 1/4] use shared infra github token --- .github/workflows/release-please.yml | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/.github/workflows/release-please.yml b/.github/workflows/release-please.yml index f61cc89..d5ca19e 100644 --- a/.github/workflows/release-please.yml +++ b/.github/workflows/release-please.yml @@ -14,9 +14,16 @@ jobs: - name: Checkout code uses: actions/checkout@v4 + - name: Generate token + id: generate_token + uses: chanzuckerberg/github-app-token@v1.1.4 + with: + app_id: ${{ secrets.CZI_RELEASE_PLEASE_APP_ID }} + private_key: ${{ secrets.CZI_RELEASE_PLEASE_PK }} + - name: Run release-please uses: google-github-actions/release-please-action@v3 with: release-type: python - token: ${{ secrets.GITHUB_TOKEN }} + token: ${{ steps.generate_token.outputs.token }} bump-minor-pre-major: true \ No newline at end of file From 7ace84c542024377d6a48eaf5eaef74c7c252336 Mon Sep 17 00:00:00 2001 From: Nina Bernick Date: Thu, 1 Aug 2024 09:54:44 -0700 Subject: [PATCH 2/4] update action --- .github/workflows/release-please.yml | 40 +++++++++++++--------------- 1 file changed, 19 insertions(+), 21 deletions(-) diff --git a/.github/workflows/release-please.yml b/.github/workflows/release-please.yml index d5ca19e..a2d3ee3 100644 --- a/.github/workflows/release-please.yml +++ b/.github/workflows/release-please.yml @@ -1,29 +1,27 @@ name: Release Please - on: push: branches: - main - +concurrency: + group: ${{ github.workflow }}-${{ github.ref }} + cancel-in-progress: true +name: release-please jobs: - release: - name: Run release-please - runs-on: ubuntu-latest - + release-please: + runs-on: [ARM64, self-hosted, Linux] steps: - - name: Checkout code - uses: actions/checkout@v4 - - - name: Generate token - id: generate_token - uses: chanzuckerberg/github-app-token@v1.1.4 - with: - app_id: ${{ secrets.CZI_RELEASE_PLEASE_APP_ID }} - private_key: ${{ secrets.CZI_RELEASE_PLEASE_PK }} + # See https://docs.github.com/en/actions/security-guides/automatic-token-authentication#using-the-github_token-in-a-workflow + # For why we need to generate a token and not use the default + - name: Generate token + id: generate_token + uses: tibdex/github-app-token@v2 + with: + app_id: ${{ secrets.CZI_RELEASE_PLEASE_APP_ID }} + private_key: ${{ secrets.CZI_RELEASE_PLEASE_PK }} - - name: Run release-please - uses: google-github-actions/release-please-action@v3 - with: - release-type: python - token: ${{ steps.generate_token.outputs.token }} - bump-minor-pre-major: true \ No newline at end of file + - name: release please + uses: googleapis/release-please-action@v4 + id: release + with: + token: ${{ steps.generate_token.outputs.token }} \ No newline at end of file From 1798135da409e23cf0f7444d78313a76cf6bee2d Mon Sep 17 00:00:00 2001 From: Nina Bernick Date: Thu, 1 Aug 2024 09:58:54 -0700 Subject: [PATCH 3/4] use our specific release please settings --- .github/workflows/release-please.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/release-please.yml b/.github/workflows/release-please.yml index a2d3ee3..5f41569 100644 --- a/.github/workflows/release-please.yml +++ b/.github/workflows/release-please.yml @@ -1,4 +1,3 @@ -name: Release Please on: push: branches: @@ -24,4 +23,6 @@ jobs: uses: googleapis/release-please-action@v4 id: release with: - token: ${{ steps.generate_token.outputs.token }} \ No newline at end of file + release-type: python + token: ${{ steps.generate_token.outputs.token }} + bump-minor-pre-major: true \ No newline at end of file From 63b9b9d7dfd39c6178d77eaebd26a73b2cb0dfb4 Mon Sep 17 00:00:00 2001 From: Nina Bernick Date: Thu, 1 Aug 2024 11:08:23 -0700 Subject: [PATCH 4/4] update infra --- .github/workflows/release-please.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release-please.yml b/.github/workflows/release-please.yml index 5f41569..9c616a6 100644 --- a/.github/workflows/release-please.yml +++ b/.github/workflows/release-please.yml @@ -8,7 +8,7 @@ concurrency: name: release-please jobs: release-please: - runs-on: [ARM64, self-hosted, Linux] + runs-on: ubuntu-latest steps: # See https://docs.github.com/en/actions/security-guides/automatic-token-authentication#using-the-github_token-in-a-workflow # For why we need to generate a token and not use the default