Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline functions #6

Open
Gaming32 opened this issue Nov 7, 2022 · 1 comment
Open

Inline functions #6

Gaming32 opened this issue Nov 7, 2022 · 1 comment

Comments

@Gaming32
Copy link

Gaming32 commented Nov 7, 2022

I've noticed that no functions in this class are inline. While the performance benefits of inlining here are maybe minimal, non-inlined functions each generate their own class (in Kotlin <1.8.0, unless configured otherwise), which leads to a lot of classes. This large number of classes also increases build times and code analysis considerably. (IntelliJ takes multiple minutes to optimize the imports on a 1000 line file that uses this library, while other files take a matter of seconds.)

@Gaming32
Copy link
Author

Gaming32 commented Nov 9, 2022

Additionally, inline function arguments can do more fancy things like non-local returns and calling suspend functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant