Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New request] Add the possibility to track custom player based on AVPlayer #4

Open
fredhdroz opened this issue Jun 6, 2017 · 1 comment
Open

[New request] Add the possibility to track custom player based on AVPlayer #4

fredhdroz opened this issue Jun 6, 2017 · 1 comment

Comments

@fredhdroz
Copy link

For an SDK, the "MediaPlayerTracker" is a bit too restrictive. It only allows to track the deprecated "MPMoviePlayerController"... It should be possible to track any custom player using AVPlayer.

Is there any protocol we could implement to track any AVPlayer ?
@ollieatkinson
Copy link

ollieatkinson commented Oct 18, 2018 •
edited
Loading

This would be really good, I also noticed we are getting a warning when compiling.

Pods/Chartbeat/Chartbeat.framework/Headers/MediaPlayerTracker.h:29:28: 'MPMoviePlayerController' is deprecated: first deprecated in iOS 9.0 - Use AVPlayerViewController in AVKit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ollieatkinson @fredhdroz