Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next/previous post keyboard navigation broken by filtered comments #1029

Open
imsodin opened this issue Jan 21, 2025 · 0 comments
Open

Next/previous post keyboard navigation broken by filtered comments #1029

imsodin opened this issue Jan 21, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@imsodin
Copy link

imsodin commented Jan 21, 2025

Site

phanpy.social

Version

2024.12.28.119d4b0

Instance

social.linux.pizza

Browser

Firefox 133.0.3 on linux with flatpak

Bug description

I hid some fairly pupolar keywords today. And then noticed keyboard navigation with j/k gets stuck at some posts. Looking at the html source, the next comment is hidden. Well I couldn't quickly spot why/how it was hidden, but it's shown as grey so I assume that's it. Neither did I find any good way to copy-paste parts of the inspector html. I expect the screenshot plus the simplicity to reproduce this should be enough, but obviously if you want more info I am happy to provide it - please let me know what/how.

On this screenshot you see the grey list/comment entry in the middle. I get stuck navigating with keys j/k both from below or above it.

Screenshot of html inspector of the list of comments where navigation gets stuck - comment where it gets stuck is shown as grey

To reproduce

  1. Add mastodon keyword filters fully hiding comments (that have an effect on some timeline of yours).
  2. Go to that timeline, keep navigating down with keyboard shortcut j.
  3. You'll get stuck eventually, as in pressing j has no effect, the selected/active comment doesn't move down anymore.
  4. Check browser console to inspect html and you'll hopefully find a comment that was filtered as the next entry.

Expected behavior

I can continue navigating, hidden comments are simply skipped.

Other

I searched for existing issues but didn't find any. There are a lot of issues though, so I am not that confident that I missed it, I hope not.

@imsodin imsodin added the bug Something isn't working label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants