Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to pull licenses from remote rebar deps #194

Open
tduffield opened this issue Jan 30, 2019 · 0 comments
Open

Add support to pull licenses from remote rebar deps #194

tduffield opened this issue Jan 30, 2019 · 0 comments

Comments

@tduffield
Copy link
Contributor

Right now, if an erlang dep defined in the rebar.lockis not present on disk when a scan occurs, we silently ignore it. This is an artifact of the v1 implementation. This was never a problem for v1 because it almost always ran in a context immediately after a build, so all the deps were on disk via that build.

However, in the v2 implementation, there is no guarantee that the deps will be on disk when a scan occurs. This is the case in pre-merge CI, and if we are optimizing by only building on a subset of the packages that may have changed.

A workaround right now is to, before scanning, iterate through all your erlang apps and make sure to perform a full build before doing a scan.

The long term fix however is two-fold:

  1. Support searching for the license based on the git_url provided by rebar_lock_json
  2. Raise an error if we detect a dep in rebar lock, but can not find it on disk.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant