Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why this interface exists #78

Open
lpatiny opened this issue Aug 7, 2023 · 0 comments
Open

Why this interface exists #78

lpatiny opened this issue Aug 7, 2023 · 0 comments
Assignees

Comments

@lpatiny
Copy link
Member

lpatiny commented Aug 7, 2023

The new eslint rules forbid to have the following pattern and it is not clear for me why this Interface exists:

export interface Spectrum2DGenerator {
addPeaks(peaks: Peak2D[] | Peak2DSeries, options?: AddPeak2DOptions): void;
addPeak(peak: Peak2D, options?: AddPeak2DOptions): void;
getSpectrum(options?: GetSpectrum2DOptions | boolean): void;
reset(): void;
}
export class Spectrum2DGenerator implements Spectrum2DGenerator {
private from: XYNumber;
private to: XYNumber;
private nbPoints: XYNumber;
public interval: XYNumber;
private data: Data2D;
private maxPeakHeight: number;

@jobo322 Could you check and fix this issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants