From 5bb7c9c29af0328154c5c1883d6b9bc8094e348d Mon Sep 17 00:00:00 2001
From: Vishal Mhatre <vishal.mhatre@gmail.com>
Date: Tue, 28 Jan 2025 16:37:20 -0800
Subject: [PATCH] Addressing PR feedback: Iteration 1

---
 Cargo.lock                                  | 8 ++++++++
 Cargo.toml                                  | 1 +
 rom/dev/tools/mldsa_key_pair_gen/Cargo.toml | 7 ++-----
 3 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/Cargo.lock b/Cargo.lock
index 37825f208f..1544477282 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -1778,6 +1778,14 @@ version = "0.2.1"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "68354c5c6bd36d73ff3feceb05efa59b6acb7626617f4962be322a825e61f79a"
 
+[[package]]
+name = "mldsa_key_pair_gen"
+version = "0.1.0"
+dependencies = [
+ "fips204",
+ "rand",
+]
+
 [[package]]
 name = "nix"
 version = "0.11.1"
diff --git a/Cargo.toml b/Cargo.toml
index 56f03793ca..8cdf64f3ff 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -75,6 +75,7 @@ members = [
   "image/fake-keys",
   "lms-types",
   "rom/dev",
+  "rom/dev/tools/mldsa_key_pair_gen",
   "rom/dev/tools/test-fmc",
   "rom/dev/tools/test-rt",
   "test",
diff --git a/rom/dev/tools/mldsa_key_pair_gen/Cargo.toml b/rom/dev/tools/mldsa_key_pair_gen/Cargo.toml
index 4a9ebfacc7..c77609a35a 100644
--- a/rom/dev/tools/mldsa_key_pair_gen/Cargo.toml
+++ b/rom/dev/tools/mldsa_key_pair_gen/Cargo.toml
@@ -7,9 +7,6 @@ edition = "2021"
 
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
-[workspace]
-
 [dependencies]
-fips204 = "0.4.5"
-rand = "0.8.5"
-zerocopy = "0.8.13"
+fips204.workspace = true
+rand.workspace = true
\ No newline at end of file