From 9f85dbabbfe506fe6e87b216f566ca5b7eeacc5d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Romain=20Tarti=C3=A8re?= Date: Tue, 3 Sep 2024 10:04:09 -0700 Subject: [PATCH] Fix some style issues in Puppet manifests These checks are performed on the Puppet Forge to give quality scores to modules, and are failing for the choria repositories: * The `ensure` parameter must be the first one in resource declaration; * Non-interpolated strings should be single, not double-quoted. While these changes are gratuitous, they will allow the scoring of the modules to increase, giving users a more positive view of the care taken to maintain them. --- moduleroot/manifests/init.pp.erb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/moduleroot/manifests/init.pp.erb b/moduleroot/manifests/init.pp.erb index 46e1072..5eb47b2 100644 --- a/moduleroot/manifests/init.pp.erb +++ b/moduleroot/manifests/init.pp.erb @@ -24,9 +24,10 @@ class <%= choria_module_name %> ( Hash $server_config = {}, Boolean $client = $mcollective::client, Boolean $server = $mcollective::server, - Enum["present", "absent"] $ensure = "present" + Enum['present', 'absent'] $ensure = 'present' ) { mcollective::module_plugin{$name: + ensure => $ensure, config_name => $config_name, client_files => $client_files, server_files => $server_files, @@ -48,6 +49,5 @@ class <%= choria_module_name %> ( server_config => $server_config, client => $client, server => $server, - ensure => $ensure } }