Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How should filters be updated or modified #27

Open
salcode opened this issue Apr 6, 2017 · 1 comment
Open

How should filters be updated or modified #27

salcode opened this issue Apr 6, 2017 · 1 comment

Comments

@salcode
Copy link
Contributor

salcode commented Apr 6, 2017

I think it is worth considering whether it makes sense to detect filters in the way proposed in #24

In that issue @GaryJones writes:

There are some filters that are not prefixed with genesis_ which should be checked for:

  • get_the_content_limit
  • get_the_content_limit_more_link
  • get_the_content_limit_allowedtags
  • the_content_limit
  • g_ent (deprecated in 2.0.0)

In #26 @srikat mentions his own fork, which forgoes filters entirely, which I think is an interesting approach. Personally, I only ever use this plugin to display the actions and I wonder if others use the plugin in the same way (i.e. might it make sense to drop filters entirely)

@christophercochran
Copy link
Owner

@salcode Filters are so weird, and some have very specific needs, I'm not sure it will be possible to completely automate. There also becomes the challenge of how do you visually represent some of these filters.

For removing them, I could, though my vision with this plugin has always been a super simple guide to find the hook or filter you need simple and easily without disrupting the workflow too much. I will admit, because of filters function in their current state, there is little use unless you know all the arguments, and other details of the filter.

One my future wants and thought is to create a reference guide in the admin, especially for these filters, that will give more details on the hook and how to use it properly. Where in the index 'visual' hooks can be linked to on the site, and taken there to see where it is, as well as linking to the reference guide from the front end to the admin, for additional details if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants