Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GWS.COMMONCONTROLS.11.2v0.3 does not detect setting inheritance #465

Closed
adhilto opened this issue Oct 7, 2024 · 3 comments · Fixed by #499
Closed

GWS.COMMONCONTROLS.11.2v0.3 does not detect setting inheritance #465

adhilto opened this issue Oct 7, 2024 · 3 comments · Fixed by #499
Labels
bug This issue or pull request addresses broken functionality
Milestone

Comments

@adhilto
Copy link
Collaborator

adhilto commented Oct 7, 2024

🐛 Summary

GWS.COMMONCONTROLS.11.2v0.3 does not detect setting inheritance (for both OUs and groups)

To reproduce

  1. Follow https://github.com/cisagov/ScubaGoggles/blob/main/baselines/commoncontrols.md#gwscommoncontrols112v03-instructions. Ensure there is an event for the top-level OU
  2. Make a child OU or a group non-compliant.
  3. Click "Inherit" (or "Unset" for a group).
  4. Run ScubaGoggles. The child OU or group will still show as non-compliant.

Expected behavior

The child OU / group to show as compliant if it inherits from its parent.

Any helpful log output or screenshots

N/A

@adhilto adhilto added the bug This issue or pull request addresses broken functionality label Oct 7, 2024
@snarve snarve added this to the Driftwood milestone Oct 15, 2024
@snarve
Copy link
Collaborator

snarve commented Dec 4, 2024

This is moved to 10.5

Related issue and PR:
#487

#318

Can this be closed?

@adhilto
Copy link
Collaborator Author

adhilto commented Dec 5, 2024

This is moved to 10.5

Related issue and PR: #487

#318

Can this be closed?

Moving to the control to a different policy group wouldn't resolve the underlying bug. Leave open until we test and confirm the issue is resolved. It's good to note the new number though, your comment should help whoever takes this issue.

@adhilto adhilto mentioned this issue Dec 11, 2024
13 tasks
@adhilto
Copy link
Collaborator Author

adhilto commented Dec 11, 2024

This setting can be queried using the policy API, so this issue will be fixed in #499.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants