Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "TimeStampZulu" to "TimestampZulu" #522

Open
adhilto opened this issue Dec 16, 2024 · 0 comments
Open

Change "TimeStampZulu" to "TimestampZulu" #522

adhilto opened this issue Dec 16, 2024 · 0 comments
Milestone

Comments

@adhilto
Copy link
Collaborator

adhilto commented Dec 16, 2024

💡 Summary

Change "TimeStampZulu" to "TimestampZulu" (in the ScubaResults.json output file) for consistency with ScubaGear.

Motivation and context

ScubaGoggles uses TimeStampZulu whereas ScubaGear uses TimestampZulu. This difference in capitalization may increase complexity for downstream systems that process data from both tools.

Implementation notes

ScubaGear relevant source code: https://github.com/cisagov/ScubaGear/blob/1205106ddf15ba1bccf8c08f0b89b4e5241bc790/PowerShell/ScubaGear/Modules/Orchestrator.psm1#L1100

ScubaGoggles relevant source code:

"TimeStampZulu": timestamp_zulu

Acceptance criteria

Capitalization has been standardized.

@adhilto adhilto added this to the Eel milestone Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant