From 4c737bab25ecbc1db06b20aed6e0ba0b9d091f96 Mon Sep 17 00:00:00 2001 From: matthewswspence Date: Tue, 14 Jan 2025 16:07:12 -0600 Subject: [PATCH] clean up for PR --- src/registrar/tests/test_admin.py | 4 ---- src/registrar/views/transfer_user.py | 9 ++------- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/src/registrar/tests/test_admin.py b/src/registrar/tests/test_admin.py index 0cc75d6e2..8baf5e42d 100644 --- a/src/registrar/tests/test_admin.py +++ b/src/registrar/tests/test_admin.py @@ -2882,10 +2882,6 @@ def test_transfer_user_throws_transfer_and_delete_success_messages(self): submit_form["selected_user"] = self.user2.pk after_submit = submit_form.submit().follow() - print("mock_success_message.call_args_list:") - for call in mock_success_message.call_args_list: - print(call) - self.assertContains(after_submit, "

Change user

") mock_success_message.assert_any_call( diff --git a/src/registrar/views/transfer_user.py b/src/registrar/views/transfer_user.py index e10a5f3fc..fdef91b43 100644 --- a/src/registrar/views/transfer_user.py +++ b/src/registrar/views/transfer_user.py @@ -1,22 +1,18 @@ import logging from django.db import transaction -from django.db.models import Manager, ForeignKey, OneToOneField, ManyToManyField, ManyToOneRel +from django.db.models import ForeignKey, OneToOneField, ManyToManyField, ManyToOneRel from django.shortcuts import render, get_object_or_404, redirect from django.views import View -from registrar import models from registrar.models.domain import Domain -from registrar.models.domain_information import DomainInformation from registrar.models.domain_request import DomainRequest -from registrar.models.portfolio import Portfolio from registrar.models.user import User from django.contrib.admin import site from django.contrib import messages from registrar.models.user_domain_role import UserDomainRole from registrar.models.user_portfolio_permission import UserPortfolioPermission -from registrar.models.verified_by_staff import VerifiedByStaff -from typing import Any, List +from typing import List logger = logging.getLogger(__name__) @@ -85,7 +81,6 @@ def post(self, request, user_id): logger.debug("Deleting old user") selected_user.delete() messages.success(request, f"Deleted {selected_user} {selected_user.username}") - except Exception as e: messages.error(request, f"An error occurred during the transfer: {e}") logger.error(f"An error occurred during the transfer: {e}", exc_info=True)