Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow non-org model domain requests for federal agencies in a portfolio #3317

Open
1 task
abroddrick opened this issue Jan 9, 2025 · 2 comments · May be fixed by #3408
Open
1 task

Don't allow non-org model domain requests for federal agencies in a portfolio #3317

abroddrick opened this issue Jan 9, 2025 · 2 comments · May be fixed by #3408
Assignees
Labels
analytics involved calculating system performance in some way dev issue is for the dev team Feature: 🏢 Org Model

Comments

@abroddrick
Copy link
Contributor

abroddrick commented Jan 9, 2025

Issue description

As an admin or similiar individual on a federal portfolio
I don't want anyone to be able to submit a domain request for my federal agency without that person being a member of my organization
so that only people trusted agency members are able to make a domain request for my agency.

Acceptance criteria

  • Once a federal portfolio exists and the domain requests flag is on, we no longer allow selecting that federal agency on the non-org model domain request flow.
    • the agency should no longer appear in the drop down on the non org model domain request flow

Additional context

Federal Agency is currently from a table so this will mean the drop down can no longer display directly from the table. You may have to preprocess with a left join with federal agency on the left and portfolios on the right.

Links to other issues

No response

@abroddrick abroddrick moved this from 👶 New to 🎯 Ready in .gov Product Board Jan 9, 2025
@abroddrick abroddrick added dev issue is for the dev team Feature: 🏢 Org Model labels Jan 13, 2025
@MzBowieFan77 MzBowieFan77 added the analytics involved calculating system performance in some way label Jan 21, 2025
@zandercymatics
Copy link
Contributor

@abroddrick Question regarding this portion of the ac: and the domain requests flag is on. Since waffle flags can be configured per user, how would we want to handle that in this case? Would this only apply if the user themselves have the organization_feature + organization_requests waffle flag, but aren't presently in a portfolio?

@abroddrick
Copy link
Contributor Author

For domain requests and Member management we will not be turning on waffle flags on a per user basis and will instead use them like switches, on or off.

@zandercymatics zandercymatics self-assigned this Jan 23, 2025
@zandercymatics zandercymatics moved this from 🎯 Ready to 🏗 In progress in .gov Product Board Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analytics involved calculating system performance in some way dev issue is for the dev team Feature: 🏢 Org Model
Projects
Status: 🏗 In progress
3 participants