Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use ProxyFix #21

Open
seanh opened this issue Nov 12, 2014 · 0 comments
Open

Don't use ProxyFix #21

seanh opened this issue Nov 12, 2014 · 0 comments
Labels
bug

Comments

@seanh
Copy link
Contributor

seanh commented Nov 12, 2014

ckanserviceprovider always uses the werkzeug proxyfix middleware:

https://github.com/ckan/ckan-service-provider/blob/master/ckanserviceprovider/web.py#L130

(apparently to make it work with gunicorn: 99b675d)

But the docs say:

Do not use this middleware in non-proxy setups for security reasons.

Should we be using this?
@seanh seanh added the bug label Nov 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@seanh