Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review ckeditor5 imports in the emoji package #17663

Closed
pomek opened this issue Dec 17, 2024 · 3 comments
Closed

Review ckeditor5 imports in the emoji package #17663

pomek opened this issue Dec 17, 2024 · 3 comments
Labels
package:emoji resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). squad:platform Issue to be handled by the Platform team. type:task This issue reports a chore (non-production change) and other types of "todos".

Comments

@pomek
Copy link
Member

pomek commented Dec 17, 2024

Provide a description of the task

I found imports like this:

import { ButtonView, View, ViewCollection } from 'ckeditor5/src/ui.js';
import { FocusTracker, KeystrokeHandler, type Locale } from 'ckeditor5/src/utils.js';

All imports should be done using the ckeditor5 package.

Let's review all ckeditor5 imports before the final merge.

@pomek pomek added package:emoji squad:platform Issue to be handled by the Platform team. type:task This issue reports a chore (non-production change) and other types of "todos". labels Dec 17, 2024
@pomek
Copy link
Member Author

pomek commented Dec 18, 2024

Please, review CSS class names, too.

@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Jan 9, 2025
@pomek
Copy link
Member Author

pomek commented Jan 10, 2025

Make sure to add the newly package to re-exports:

https://github.com/ckeditor/ckeditor5/blob/master/src/index.ts

@pomek
Copy link
Member Author

pomek commented Jan 15, 2025

Closing as invalid, imports are fine.

@pomek pomek closed this as not planned Won't fix, can't repro, duplicate, stale Jan 15, 2025
@pomek pomek added the resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). label Jan 15, 2025
@CKEditorBot CKEditorBot removed the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:emoji resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). squad:platform Issue to be handled by the Platform team. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Development

No branches or pull requests

2 participants