Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password manager (1Password) appears in hyperlink dialogue #17708

Open
mprofitlich opened this issue Jan 2, 2025 · 2 comments
Open

Password manager (1Password) appears in hyperlink dialogue #17708

mprofitlich opened this issue Jan 2, 2025 · 2 comments
Labels
domain:ui/ux This issue reports a problem related to UI or UX. type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@mprofitlich
Copy link

📝 When setting a hyperlink 1Password pops up

The hyperlink dialogue is totally fine in itself. Only 1Password recognises it as a field that the user might want to fill through 1Password. The two buttons Save and Cancel get hidden behind the 1Password button.

I suggest to add the data-1p-ignore attribute to the input field. This will tell 1Password to ignore the field. See 1Password documentation.

Image Image

📃 Other details

  • Browser: Firefox 133.0
  • OS: Mac OS 15.1.1
  • CKEditor version: 4.4.0 (in Craft CMS 5.5.7)
  • Installed CKEditor plugins: none

If you'd like to see this improvement implemented, add a 👍 reaction to this post.

@mprofitlich mprofitlich added the type:improvement This issue reports a possible enhancement of an existing feature. label Jan 2, 2025
@Witoso
Copy link
Member

Witoso commented Jan 7, 2025

So far AFAIK, we haven't added any application/extension specific markup to our UI's HTML, and I think we won't make a precedence. Otherwise, we would need to care about all PM, and god knows how many other use cases.

WDYT @Reinmar?

@Witoso Witoso added the domain:ui/ux This issue reports a problem related to UI or UX. label Jan 7, 2025
@Reinmar
Copy link
Member

Reinmar commented Jan 10, 2025

Sort of similar to #15220 but at the same time very different.

In #15220 we can use a standard-backed attribute to tackle a problem hopefully once and for all.

Here, we'd need to use this attribute on all inputs across the project to fix issue with just one external product. I know that browser addons can degrade user experience but it's the problem with the addons and we cannot pollute CKEditor with workarounds.

I'd recommend reporting this issue to the 1Password team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:ui/ux This issue reports a problem related to UI or UX. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

No branches or pull requests

3 participants