Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

length of coupon name causes layout issues #35

Open
extrapixel opened this issue Apr 22, 2017 · 9 comments
Open

length of coupon name causes layout issues #35

extrapixel opened this issue Apr 22, 2017 · 9 comments

Comments

@extrapixel
Copy link
Contributor

Most themes aren't prepared for super long coupon names. On small resolutions prices disappear off-screen and can't be scrolled to. On mobile, this results in prices / totals not being visible at all without a way to make it visible.

Example: Storefront
screen shot 2017-04-22 at 01 46 49

Strictly speaking, this is a theme issue and can be solved by custom CSS.

However, also for usability, I'd prefer something that is very short and human readable. E.g. "3% BACS". Using the woocommerce_cart_totals_coupon_label filter maybe?

A quick solution would be to use "-" instead of "_" so the browser can break the line.

@Wegerich
Copy link

capture
I am having the same issue, but for me it is overlapping the "popular products widget".

I love the use of coupons but agree that I would like - instead of _

@lotuzwine
Copy link

There is a major breach on this pluggin. You can get this cupom code and apply to any payment method. I dont think this should be allowed. I really should search for an alternative to this pluggin.

@extrapixel
Copy link
Contributor Author

@lotuzwine I've thought the same at first. But try it.

@lotuzwine
Copy link

I actually tried and applied the discount using a credit card payment method, which should not have any discount at all.

@extrapixel
Copy link
Contributor Author

I've just tried it (again - it was the first i tried with the new version). While it says "coupon applied" at the messages, it doesn't actually apply it. Try it again and pay attention to the totals.

The actual issue is the message "coupon applied" appearing. It should not. But nobody can cheat (not on my installation at least).

@Wegerich
Copy link

I can confirm that the coupon code "successfully" applies to other payment methods but it gives a discount of zero. Please create a separate thread for this as it is not related to the topic.

@lotuzwine
Copy link

Thread created.

@sarinalustosa
Copy link

Does someone was able to solve this problem? I'm having the same problem.

@extrapixel
Copy link
Contributor Author

@claudiosanches why don't you just change the '_' character to '-' ?

such a low hanging fruit. if you care, just do it. It has been 3 years... it's time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants